core(without-javascript): remove audit

[Beytoven]

Fixes #11459.

[adamraine]

In addition to the CI failures, I found some files which still reference this audit:

• lighthouse-cli/test/smokehouse/test-definitions/offline-local/offline-config.js Related to smoke failures?
• lighthouse-treemap/app/debug.json @connorjclark should we update in this PR?

Additionally, the HTMLWithoutJavascript gatherer is only used for this audit, should we remove this too?

[connorjclark]

lighthouse-treemap/app/debug.json @connorjclark should we update in this PR?

Nah we don't have too. I suppose if we wanted to it'd be ok. could just remove every audit in that LHR except for script-treemap-data | large-javascript-libraries | unused-javascript | source-maps | valid-source-maps

[patrickhulce]

New idea for a replacement: we could take a screenshot of the page without javascript and run the speed index algorithm on it, if it's more than ~20% different it fails? If there's interest I can file an issue with more details :)

[patrickhulce]

one other note on the changes necessary here, we'll probably want to simplify the flow and remove the disableJavaScript handling in driver as well :)

[Beytoven]

New idea for a replacement: we could take a screenshot of the page without javascript and run the speed index algorithm on it, if it's more than ~20% different it fails? If there's interest I can file an issue with more details :)

Just to be clear, you're proposing this as an alternative to removing the 'without-js' audit completely, right?

[patrickhulce]

Just to be clear, you're proposing this as an alternative to removing the 'without-js' audit completely, right?

A long-term alternative yes, but my proposal shouldn't block the landing of this PR. I commented here to keep discussion about why it's OK to remove this in one logical place :)

[brendankenny]

smoke test failure for now-possible js redirects is an interesting new case :)

[adamraine]

One last remnant I noticed:

lighthouse/lighthouse-core/test/results/artifacts/artifacts.json

Lines 3342 to 3344 in 80b9db0

	"HTMLWithoutJavaScript": {
	"bodyText": "Do better web tester page\nHi there!\ntouchmove section\n "
	},

[adamraine]

LGTM