Store state of lighthouse in extension while running. #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When extension popup is closed & lighthouse is still running we show the state lighthouse is running in instead of showing the startup screen.
wardpeet
force-pushed
the
extension-save-state
branch
from
e5a0776
to
3ac3baa
Compare
| @@ -128,6 +128,10 @@ document.addEventListener('DOMContentLoaded', _ => { | |||
| return frag; | |||
| } | |||
|
|
|||
| if (background.isRunning()) { | |||
| startSpinner(); | |||
There was a problem hiding this comment.
not super familiar with the code here, but i'm assuming we're already stopping the spinner everywhere we need to? :)
There was a problem hiding this comment.
Yes whenever runner fails promise then or catch than we do a stopSpinner. Not sure if Start and Stop spinner is still a good name for it. Maybe something a long the lines of showProcessPage or just showProcess?
| @@ -213,7 +227,20 @@ window.loadSelectedAggregations = function() { | |||
| }; | |||
|
|
|||
| window.listenForStatus = function(callback) { | |||
| log.events.addListener('status', callback); | |||
| log.events.addListener('status', function(args) { | |||
There was a problem hiding this comment.
nit: maybe just log or something other than args? staring at it a bit assuming it was a list ala arguments and not just the one input
There was a problem hiding this comment.
thanks :) sounds better indeed 👍
ebidel
approved these changes
Dec 30, 2016
|
This is killer. nice work @wardpeet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extension popup is closed & lighthouse is still running we show the state lighthouse is running in instead of showing the startup screen.
