Update extension badge text when LH is running #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested changes
Jan 3, 2017
| @@ -90,17 +109,16 @@ window.runLighthouseForConnection = function(connection, url, options, requested | |||
| // Add url and config to fresh options object. | |||
| const runOptions = Object.assign({}, options, {url, config}); | |||
|
|
|||
| lighthouseIsRunning = true; | |||
There was a problem hiding this comment.
I'd prefer to keep the explicit lighthouseIsRunning = true; inline here and below but call a updateBadgeUI() immediately after each.
paulirish
reviewed
Jan 3, 2017
| function updateBadgeUI(optUrl) { | ||
| if (window.chrome && chrome.runtime) { | ||
| const manifest = chrome.runtime.getManifest(); | ||
| const title = optUrl ? `Testing ${optUrl}` : manifest.browser_action.default_title; |
There was a problem hiding this comment.
now we can use lighthouseIsRunning for these conditionals. that work for you?
|
thanks for merging, sorry wasn't available:) |
andrewrota
pushed a commit
to andrewrota/lighthouse
that referenced
this pull request
Jan 13, 2017
* Update extension badge text when LH is running * feedback * update method name * Use lighthouseIsRunning var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @paulirish @wardpeet all
This expands on #1185 by updating the tooltip and badge text when LH is testing a page. Makes it more obvious something is going on if the popup has been dismissed.