Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(network): do not consider cross frame requests critical #11851

Merged
merged 3 commits into from
Dec 17, 2020
Merged

core(network): do not consider cross frame requests critical #11851

merged 3 commits into from
Dec 17, 2020

Conversation

patrickhulce
Copy link
Collaborator

Summary
Ignores child frame requests for the new isCriticalIdle check. Solves the most important consequence of #11850 that will be introduced with 7.0

Related Issues/PRs
#11850

@patrickhulce patrickhulce requested a review from a team as a code owner December 17, 2020 17:03
@patrickhulce patrickhulce requested review from adamraine and removed request for a team December 17, 2020 17:03
@google-cla google-cla bot added the cla: yes label Dec 17, 2020
@patrickhulce patrickhulce added 7.0 and removed cla: yes labels Dec 17, 2020
@google-cla
Copy link

google-cla bot commented Dec 17, 2020

☹️ Sorry, but only Googlers may change the label cla: yes.

@google-cla google-cla bot added the cla: yes label Dec 17, 2020
adamraine
adamraine approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickhulce @brendankenny
Apply suggestions from code review
2464655 
Co-authored-by: Brendan Kenny <bckenny@gmail.com>
@devtools-bot devtools-bot merged commit 91092fc into master Dec 17, 2020
@devtools-bot devtools-bot deleted the ignore_other_frames_critical_idle branch December 17, 2020 18:06
paulirish pushed a commit that referenced this pull request Mar 23, 2021
@patrickhulce @paulirish
core(network): do not consider cross frame requests critical (#11851)
df6fd7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny left review comments

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
cla: yes waiting4committer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickhulce @brendankenny @adamraine @devtools-bot