-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(csp-xss): csp evaluator npm module #12221
Conversation
@@ -16,63 +15,6 @@ const { | |||
|
|||
/* eslint-env jest */ | |||
|
|||
describe('Evaluator compatibility', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just a sanity check since the previous method of importing CSP evaluator was irregular. We shouldn't need it now.
const results = [ | ||
...findings.map(this.findingToTableItem), | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
/** | ||
* @param {string[]} rawCsps | ||
*/ | ||
function evaluateRawCspForFailures(rawCsps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helper functions added so i didn't need to change every single test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor things but otherwise lgtm
npm module is published #12044 (comment)
We can get rid of the google3 binary and the irregular method of importing.
Reduces devtools bundle size by ~45KB.