core(csp-xss): hidden severity

[adamraine]

Can land after #12221

When there is no CSP, we now use a table item with severity icon instead of the audit display value. If we just use the display value, the audit state for "no csp" will look very similar to the audit state for "csp is all good".

Before:

After:

[adamraine]

#12221 (comment) Proposal to move directive column to the left.

[adamraine]

Looks pretty weird for findings with no directive.

[paulirish]

as discussed, we'll drop the icons. and yeah lets keep directive as the last column.

you said you wanted to keep some other changes in here, so i'll let you take that.

[connorjclark]

reminder to change the PR title

[adamraine]

Having the icons available in the LHR might still be useful for testing. Additionally, I still think having "No CSP in enforcement mode" as a table item is preferable to having it as the display value.

[brendankenny]

Having the icons available in the LHR might still be useful for testing.

Since they'll be hidden, can the new icon audit-details type be dropped until we need it?

[adamraine]

Since they'll be hidden, can the new icon audit-details type be dropped until we need it?

I removed the icon code from the report renderer, but I don't think I can remove the type entirely.

[brendankenny]

couldn't they just be text (e.g. just the current tooltip value) in a "severity" column? e.g. iconName isn't important if it's just for testing for now.

[adamraine]

Could we land this? At this point, it's just a few minor tweaks.