core(driver): move evaluateOnNewDocument to executionContext #12381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
commented
Apr 20, 2021
| __nativePromise: PromiseConstructor; | ||
| __nativeURL: URL; | ||
| __nativePerformance: Performance; | ||
| __nativeURL: typeof URL; |
There was a problem hiding this comment.
this was typed incorrectly, but we never use it :)
patrickhulce
force-pushed
the
fr_refactor_cache_natives
branch
from
617f9db
to
8daccd5
Compare
connorjclark
approved these changes
Apr 20, 2021
| * Evaluate a function on every new frame from now on. | ||
| * @template {any[]} T | ||
| * @param {((...args: T) => void)} mainFn The main function to call. | ||
| * @param {{args: T, deps?: Array<Function|string>}} options `args` should |
| @@ -83,11 +85,10 @@ class ExecutionContext { | |||
| // 3. Ensure that errors captured in the Promise are converted into plain-old JS Objects | |||
| // so that they can be serialized properly b/c JSON.stringify(new Error('foo')) === '{}' | |||
| expression: `(function wrapInNativePromise() { | |||
| const __nativePromise = globalThis.__nativePromise || Promise; | |||
| const URL = globalThis.__nativeURL || globalThis.URL; | |||
| ${ExecutionContext._cachedNativesPreamble}; | |||
Co-authored-by: Brendan Kenny <bckenny@gmail.com>
…ighthouse into fr_refactor_cache_natives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split out from #12366 and follow up to #12365, this moves the script evaluation on new document logic to executionContext, and aligns its call signature with our new preferred
evaluatesyntax that can be typechecked. This also completes the colocation of all the cached native definition and usage (except ElementMatches), so no need to referencewindow.__nativePromiseever again :DRelated Issues/PRs
ref #11313 #12366