tests(smoke): add _excludes and _runner #13707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Feb 25, 2022
|
|
||
| // Because we may be deleting keys, we should iterate the keys backwards | ||
| // otherwise arrays with multiple pruning checks will skip elements. | ||
| for (const [key, value] of Object.entries(obj).reverse()) { |
There was a problem hiding this comment.
drive by bug fix
connorjclark
commented
Feb 25, 2022
| /** | ||
| * @param {string} key | ||
| */ | ||
| const remove = (key) => { |
There was a problem hiding this comment.
drive by simplification
adamraine
approved these changes
Feb 28, 2022
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #13705