tests: add more cases for oopif smoke test #13705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Feb 25, 2022
connorjclark
commented
Feb 25, 2022
connorjclark
changed the title
connorjclark
commented
Feb 25, 2022
| {url: 'http://localhost:10503/oopif-simple-page.html'}, | ||
| // simple-script.js is included many times | ||
| // 2 * (1 from <script>, 1 from fetch) = 4 | ||
| // Note, the network records from the workers are _not_ captured! |
There was a problem hiding this comment.
bug alert!
adamraine
reviewed
Feb 25, 2022
| const unexpectedValues = expectedValue; | ||
| console.log({arrToCheckAgainst}); | ||
| for (const unexpectedEntry of unexpectedValues) { | ||
| const matchingIndex = arrToCheckAgainst.findIndex(actualEntry => |
There was a problem hiding this comment.
We don't do any splicing, can probably just use arrToCheckAgainst.find
There was a problem hiding this comment.
hm... but then there's the case of undefined being a valid value in these arrays :P
adamraine
approved these changes
Feb 25, 2022
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't understand under what circumstances we determine a script (via
ScriptElement) to be from an OOPIF (when the network record has a sessionId thus is not from the main target).Learned some things:
Adding more test cases to capture how things change if we decide to stop filtering "OOPIF" scripts from our audits.