tests: use cache instead of artifacts for devtools build #13840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Apr 11, 2022
|
another bonus, in #13841 i just ran into an issue re-running failed jobs because of the 1-day artifact retention we have here |
.github/workflows/devtools.yml
Outdated
| @@ -93,11 +93,15 @@ jobs: | |||
| with: | |||
| node-version: 14.x | |||
|
|
|||
| - name: Download artifact | |||
| uses: actions/download-artifact@v2 | |||
| - name: Cache build artifacts | |||
There was a problem hiding this comment.
What do you think of renaming these two? Load cached build artifacts or something? Less important for the logs, but kind of confusing when reading this file
|
Yes! Artifact upload/download is approaching unbearable levels. I'm curious if gzipping the artifact before uploading would have had similar improvements (https://twitter.com/AcidOxee/status/1512029210080129026) since you can see the file count slowly flip by in the logs, but if caching works it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes 8 minutes on the "upload artifact" side, and 2 minutes on the "download artifacts" side.
before
after
Not sure why the cache is sized at 15 MB but the artifact before was 90 MB... but the jobs are passing so...
Perhaps GH compresses better in cache action than for artifacts?
Thanks for the idea @diegohaz!