Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(legacy): create legacy directory under core #14341

Merged
merged 8 commits into from
Sep 9, 2022
Merged

Conversation

adamraine
Copy link
Member

This adds a new legacy directory under core which is meant to contain all the legacy navigation stuff. Similar file structure is also added to the test files.

In a follow up PR, the plan is to move all the stuff from core/fraggle-rock into core proper and the corresponding core/gather/core/config directories.

Way down the line (post 10.0) we need to update our tests so they don't rely on legacy fixtures.

@adamraine adamraine requested a review from a team as a code owner August 31, 2022 22:46
@adamraine adamraine requested review from brendankenny and removed request for a team August 31, 2022 22:46
@adamraine adamraine added the 10.0 label Aug 31, 2022
@vercel

This comment was marked as outdated.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📂🔀📂

@adamraine adamraine merged commit f8bb5a0 into master Sep 9, 2022
@adamraine adamraine deleted the fr-legacy-directory branch September 9, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants