added short-name-length check #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work here @samthor |
|
Would you mind adding this audit to one of the aggregators? :) |
|
Nice!!
Yah it'd work with the addto home screen aggregator.
|
samthor
force-pushed
the
short-name-length
branch
from
a5194c5
to
c264f72
Compare
|
Added. PTAL! |
|
champ 👏 ⚾ 🎉 |
| const manifest = artifacts.manifest.value; | ||
|
|
||
| if (manifest && manifest.short_name) { | ||
| // Historically, Chrome recommended 12 chars as the maximum length to prevent truncation. |
There was a problem hiding this comment.
maybe put in a mention of #69 to track while we figure out the answer there
There was a problem hiding this comment.
+1 lets link the issue as theres some valuable discussion.
samthor
force-pushed
the
short-name-length
branch
2 times, most recently
from
72900c4
to
b0d756e
Compare
|
@paulirish Thanks for the explanation of the manifest vs parsed version. I get the approach now. PTAL |
| const manifestSrc = JSON.stringify({ | ||
| short_name: 'i\'m much longer than the recommended size' | ||
| }); | ||
| const manifest = manifestParser(manifestSrc); |
There was a problem hiding this comment.
We should also verify the Debug string is attached here
|
Lgtm % nit |
|
Let's land this after deep's scheduler. (We'll have a conflict to fix) |
samthor
force-pushed
the
short-name-length
branch
from
b0d756e
to
0fb66b3
Compare
|
Cool, I can keep rebasing as long as you like 👍 |
|
Ah! looks like no conflicts. :) Not bad. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts to solve #69 with a basic assumption of 12 chars max, taken from the old Chrome extension manifest docs (which presumably evolved into the format we have today).
(Also partially just learning how to write an audit).