-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifests: highlight if short_name exceeds expected character count #69
Comments
Can you find out what character length range we should suggest?
|
Yep! |
@mounirlamouri might know! |
I do not think we do any kind of significant trimming in Chrome (there is a 4Ki limit but not what you are asking I think :)). @addyosmani where do you see the trim? Is it in the home screen? or the Chrome UI? |
I think it's more the visual wrangling you do to make sure it's not truncated on the home screen. |
@mounirlamouri I see it in the homescreen. I'll see if I can put together a repro. |
This is a smart check to have, yeah. I am pretty sure i've seen quite different results on a Nexus 6 vs a smaller phone for this number. @addyosmani have you gotten a sense of what string lengths work? |
From my homescreen.. here's what is and isn't truncated, along with string lengths: HackerWeb # 9
Play Store # 9
Pocket Cas… # 10
Chrome Ca… # 9
Popcorn Ti… # 10
What’s my… # 9
Flipkart Lite # 13
Guitar Tuner # 12
Trained To… # 10
Inbox Attack # 12
Get Kana! # 9
BusRouter… #9 By now, you can tell that Roboto doesn't use the same width for all letters. :) |
If we know widths and fonts we can guess pretty well with a |
Let me follow up with the android UI team... and see if I can get a real answer on this. |
fixed by #145 |
Afaik on the Android homescreen, if a
short_name
contains too many characters it will be trimmed to something likeMy Totally Awesome App -> My Totally Awe...
. It may be useful to check the spec or with Mounir regarding expected lengths for these app names and whether flagging this via Lighthouse makes sense.I've personally run into issues with needing to manually test this on-device (or rethink the names used) to avoid truncating, so throwing the idea out there.
The text was updated successfully, but these errors were encountered: