deps: upgrade axe-core to 4.6.3
#14690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I asked about the changes dequelabs/axe-core#3887 |
adamraine
commented
Jan 25, 2023
| role="radiogroup"> | ||
| <div></div> | ||
| role="list"> | ||
| <div>Item</div> |
There was a problem hiding this comment.
adamraine
commented
Jan 25, 2023
| @@ -190,7 +190,7 @@ <h3>sub-sub-header</h3> | |||
| </section> | |||
| <p>object-alt</p> | |||
| <section> | |||
| <object id="object-alt"></object> | |||
| <object id="object-alt" data="data:text/html,data"></object> | |||
There was a problem hiding this comment.
connorjclark
changed the title
axe-core to 4.6.2axe-core to 4.6.3
connorjclark
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dequelabs/axe-core/releases
New rules:
target-sizeSeems similar to our tap targets audittap-targetswithtarget-sizerule from Axe and put under Accessibility, not SEO #12345meta-refresh-no-exceptionsLooks like a more strict version ofmeta-refreshlink-in-text-blockMoved out of experimental. I manually disabled it for now.frame-title-uniqueis now wcag2a so we pick it up automatically. I manually disabled for now though.There are some smoke failures forobject-altandaria-required-childrenthat I couldn't figure out just looking at the change-log.This should be good now.
cc @jazyan