Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade axe-core to 4.6.3 #14690

Merged
merged 7 commits into from
Jan 25, 2023
Merged

deps: upgrade axe-core to 4.6.3 #14690

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
51de3f6
deps: upgrade `axe-core` to 4.6.2
adamraine Jan 18, 2023
d4ab38b
half smoke
adamraine Jan 18, 2023
148c768
Merge branch 'main' into axe-4.6.2
adamraine Jan 24, 2023
5252084
Merge branch 'main' into axe-4.6.2
adamraine Jan 24, 2023
711dd36
fix
adamraine Jan 25, 2023
80c619f
unit
adamraine Jan 25, 2023
4ad4d30
doc links
adamraine Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cli/test/fixtures/a11y/a11y_tester.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@
<section>
<div
id="aria-required-children"
role="radiogroup">
<div></div>
role="list">
<div>Item</div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dequelabs/axe-core#3597

</div>
</section>
<p>aria-required-parent</p>
Expand Down Expand Up @@ -190,7 +190,7 @@ <h3>sub-sub-header</h3>
</section>
<p>object-alt</p>
<section>
<object id="object-alt"></object>
<object id="object-alt" data="data:text/html,data"></object>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dequelabs/axe-core#3680

</section>
<p>tabindex</p>
<section>
Expand Down
12 changes: 6 additions & 6 deletions cli/test/smokehouse/test-definitions/a11y.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,9 @@ const expectations = {
node: {
'type': 'node',
'selector': 'body > section > div#aria-required-children',
'snippet': '<div id="aria-required-children" role="radiogroup">',
'explanation': 'Fix any of the following:\n Required ARIA child role not present: radio',
'nodeLabel': 'body > section > div#aria-required-children',
'snippet': '<div id="aria-required-children" role="list">',
'explanation': 'Fix any of the following:\n Required ARIA child role not present: listitem\n Element has no aria-busy="true" attribute',
'nodeLabel': 'Item',
},
},
],
Expand Down Expand Up @@ -360,7 +360,7 @@ const expectations = {
'type': 'node',
'selector': 'body > section > dl#definition-list',
'snippet': '<dl id="definition-list">',
'explanation': 'Fix all of the following:\n List element has direct children that are not allowed inside <dt> or <dd> elements',
'explanation': 'Fix all of the following:\n dl element has direct children that are not allowed: p',
'nodeLabel': 'body > section > dl#definition-list',
},
},
Expand Down Expand Up @@ -627,7 +627,7 @@ const expectations = {
'type': 'node',
'selector': 'body > section > ul#list',
'snippet': '<ul id="list">',
'explanation': 'Fix all of the following:\n List element has direct children that are not allowed inside <li> elements',
'explanation': 'Fix all of the following:\n List element has direct children that are not allowed: p',
'nodeLabel': 'body > section > ul#list',
},
},
Expand Down Expand Up @@ -674,7 +674,7 @@ const expectations = {
node: {
'type': 'node',
'selector': 'body > section > object#object-alt',
'snippet': '<object id="object-alt">',
'snippet': '<object id="object-alt" data="data:text/html,data">',
'explanation': 'Fix any of the following:\n aria-label attribute does not exist or is empty\n aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty\n Element has no title attribute\n Element\'s default semantics were not overridden with role="none" or role="presentation"',
'nodeLabel': 'body > section > object#object-alt',
},
Expand Down
4 changes: 3 additions & 1 deletion core/gather/gatherers/accessibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,12 @@ async function runA11yChecks() {
'frame-focusable-content': {enabled: false},
'aria-roledescription': {enabled: false},
'scrollable-region-focusable': {enabled: false},
// TODO(paulirish): create audits and enable these 3.
// TODO(paulirish): create audits and enable these 5.
'input-button-name': {enabled: false},
'role-img-alt': {enabled: false},
'select-name': {enabled: false},
'link-in-text-block': {enabled: false},
'frame-title-unique': {enabled: false},
adamraine marked this conversation as resolved.
Show resolved Hide resolved
},
});

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
},
"dependencies": {
"@sentry/node": "^6.17.4",
"axe-core": "4.4.1",
"axe-core": "4.6.3",
"chrome-launcher": "^0.15.1",
"configstore": "^5.0.1",
"csp_evaluator": "1.1.1",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2008,10 +2008,10 @@ aws4@^1.8.0:
resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.8.0.tgz#f0e003d9ca9e7f59c7a508945d7b2ef9a04a542f"
integrity sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ==

axe-core@4.4.1:
version "4.4.1"
resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.4.1.tgz#7dbdc25989298f9ad006645cd396782443757413"
integrity sha512-gd1kmb21kwNuWr6BQz8fv6GNECPBnUasepcoLbekws23NVBLODdsClRZ+bQ8+9Uomf3Sm3+Vwn0oYG9NvwnJCw==
axe-core@4.6.3:
version "4.6.3"
resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.6.3.tgz#fc0db6fdb65cc7a80ccf85286d91d64ababa3ece"
integrity sha512-/BQzOX780JhsxDnPpH4ZiyrJAzcd8AfzFPkv+89veFSr1rcMjuq2JDCwypKaPeB6ljHp9KjXhPpjgCvQlWYuqg==

babel-plugin-istanbul@^6.1.1:
version "6.1.1"
Expand Down