Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients(bundled): include soft navigation plugin #14874

Merged
merged 1 commit into from
Mar 10, 2023
Merged

clients(bundled): include soft navigation plugin #14874

merged 1 commit into from
Mar 10, 2023

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Mar 10, 2023 •
edited

Changes to bundle sizes are negligible.

@adamraine adamraine requested a review from a team as a code owner March 10, 2023 20:34
@adamraine adamraine requested review from connorjclark and removed request for a team March 10, 2023 20:34
@brendankenny
Copy link
Member

What's the purpose of adding it to the bundle if you can't run it anywhere?

@adamraine
Copy link
Member Author

Internal partners requested this plugin be included

@adamraine adamraine merged commit ae88916 into main Mar 10, 2023
@adamraine adamraine deleted the bundle-soft-navs branch March 10, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@connorjclark connorjclark Awaiting requested review from connorjclark connorjclark is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@connorjclark connorjclark

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adamraine @brendankenny @paulirish @connorjclark @devtools-bot