Report-in-Firefox fixes #1489
Closed
Report-in-Firefox fixes #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will have a look ^^ if @ebidel doesn't beat me to it 😃 |
|
Also note that this patch doesn't fix the checkbox issue; I thought I'd leave this for later. |
|
I'm almost done with the checkbox, but I'm having an issue with the position of the help text :/
Should I push that too? |
|
Let's do checkboxes in another PR. |
ebidel
reviewed
Jan 19, 2017
| @@ -1,62 +1,3 @@ | |||
| <style> | |||
There was a problem hiding this comment.
Can we restore these files and keep the related styles within the partials? That doesn't seem necessary for this PR?
There was a problem hiding this comment.
Done. I just feel that having random styles in many places isn't good. But, yeah, it was unrelated change to this PR.
Firefox doesn't display the SVGs unless they are URL encoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this since I'm not sure when I'll have more time to fix the remaining issues.
If merged, fixes #1124.
/CC @ebidel @wardpeet: feel free to push to my branch. I also kept the original patch which URL encoded the SVGs and worked everywhere but it's a little messy solution.
Also, there's a discrepancy between Chrome and Firefox: in Firefox the badges don't look properly vertically aligned but in Chrome they look fine. Not sure how to fix that only for Firefox.