Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report: fix rendering issues in FF. Fixes #1124 #1551

Merged
merged 3 commits into from
Jan 28, 2017
Merged

Report: fix rendering issues in FF. Fixes #1124 #1551

merged 3 commits into from
Jan 28, 2017

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented Jan 27, 2017

R: all

This is an alternative to #1489.

The benefit is that it keeps the SVG unencoded (easier to maintain later) and also fixes the checkboxes in firefox. Didn't touch the Beta banner for FF. Probably not worth it.

screen shot 2017-01-26 at 7 30 29 pm

@ebidel ebidel added the report label Jan 27, 2017
@Janpot
Copy link
Contributor

Janpot commented Jan 27, 2017

the beta banner seems still missing in your screenshot.

@XhmikosR
Copy link
Contributor

What @Janpot said plus the toggle help button looks bad using FF 52b1.

1498alt

Other than those 2, much cleaner solution, agreed 👍

@ebidel
Copy link
Contributor Author

ebidel commented Jan 27, 2017

I should have mentioned, I didn't touch the Beta banner for FF. Didn't think it's worth the trouble.

My screenshot is from FF54. It looks like they've fixed the behavior of -moz-appearance for checkboxes in later versions of FF.

@XhmikosR
Copy link
Contributor

All right, then I guess it makes sense to merge this but it will land on beta in like 2 months at best.

I'd still URL encode the banner though unless you plan to remove it soon :).

@ebidel
Copy link
Contributor Author

ebidel commented Jan 27, 2017

We've talked about that :)

@XhmikosR
Copy link
Contributor

All right, closing my PR then, and thanks for this!

@ebidel
Copy link
Contributor Author

ebidel commented Jan 27, 2017

Update:

This is also rocking blue "?" icons now and black headings, as per @paulirish's css changes for devtools.

screen shot 2017-01-27 at 3 40 58 pm

@ebidel ebidel requested a review from paulirish January 28, 2017 04:27
@ebidel ebidel merged commit 5fd1cfe into master Jan 28, 2017
@ebidel ebidel deleted the 1489alt branch January 28, 2017 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants