Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(bf-cache): change to use binary scoring mode #15581

Merged
merged 2 commits into from
Nov 28, 2023
Merged

core(bf-cache): change to use binary scoring mode #15581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e84ce
change to use binary scoring mode
adrianaixba Nov 1, 2023
25dbee9
nit fix
adrianaixba Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/audits/bf-cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class BFCache extends Audit {
supportedModes: ['navigation', 'timespan'],
guidanceLevel: 2,
requiredArtifacts: ['BFCacheFailures'],
scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
scoreDisplayMode: Audit.SCORING_MODES.BINARY,
};
}

Expand Down
6 changes: 3 additions & 3 deletions core/test/fixtures/user-flows/reports/sample-flow-result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3714,7 +3714,7 @@
"title": "Page didn't prevent back/forward cache restoration",
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 1,
"scoreDisplayMode": "metricSavings",
"scoreDisplayMode": "binary",
"guidanceLevel": 2
}
},
Expand Down Expand Up @@ -10645,7 +10645,7 @@
"title": "Page didn't prevent back/forward cache restoration",
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 1,
"scoreDisplayMode": "metricSavings",
"scoreDisplayMode": "binary",
"guidanceLevel": 2
}
},
Expand Down Expand Up @@ -21341,7 +21341,7 @@
"title": "Page didn't prevent back/forward cache restoration",
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 1,
"scoreDisplayMode": "metricSavings",
"scoreDisplayMode": "binary",
"guidanceLevel": 2
}
},
Expand Down
4 changes: 2 additions & 2 deletions core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5659,8 +5659,8 @@
"id": "bf-cache",
"title": "Page prevented back/forward cache restoration",
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 0.5,
"scoreDisplayMode": "metricSavings",
"score": 0,
"scoreDisplayMode": "binary",
"displayValue": "2 failure reasons",
"details": {
"type": "table",
Expand Down
Loading