Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typedefs for trace events. #1565

Merged
merged 2 commits into from
Jan 30, 2017
Merged

Add typedefs for trace events. #1565

merged 2 commits into from
Jan 30, 2017

Conversation

paulirish
Copy link
Member

No description provided.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor things, otherwise LGTM

TraceEvent.prototype.id;

/** @type {string} */
TraceEvent.prototype.id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate ids here


/**
* Typing externs file for raw trace events
* @externs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,70 @@
/**
* @license
* Copyright 2016 Google Inc. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017

@paulirish paulirish merged commit 270f70b into master Jan 30, 2017
@paulirish paulirish deleted the tracetypedef-master branch January 30, 2017 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants