Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typedefs for trace events. #1565

Merged
merged 2 commits into from
Jan 30, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions lighthouse-core/closure/typedefs/Trace.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
/**
* @license
* Copyright 2016 Google Inc. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017

*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

/**
* Typing externs file for raw trace events
* @externs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/

/**
* @struct
* @record
*/
function TraceEvent() {}

/** @type {string} */
TraceEvent.prototype.cat;

/** @type {number} */
TraceEvent.prototype.pid;

/** @type {number} */
TraceEvent.prototype.tid;

/** @type {number} */
TraceEvent.prototype.ts;

/** @type {string} */
TraceEvent.prototype.ph;

/** @type {string} */
TraceEvent.prototype.name;

/** @type {!Object} */
TraceEvent.prototype.args;

/** @type {number} */
TraceEvent.prototype.dur;

/** @type {string} */
TraceEvent.prototype.id;

/** @type {string} */
TraceEvent.prototype.id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate ids here


/** @type {string} */
TraceEvent.prototype.bind_id;


/**
* @struct
* @record
*/
function Trace() {}

/** @type {{traceEvents: !Array<!TraceEvent>}} */
Trace.prototype.traceEvents;