clients(lr): include flag for ignoring bad page status code

clients/lightrider/lightrider-entry.js

@@ -77,11 +77,11 @@ async function getPageFromConnection(connection) {
  * @param {any} connection
  * @param {string} url
  * @param {LH.Flags} flags Lighthouse flags
- * @param {{lrDevice?: 'desktop'|'mobile', categoryIDs?: Array<string>, logAssets: boolean, configOverride?: LH.Config}} lrOpts Options coming from Lightrider
+ * @param {{lrDevice?: 'desktop'|'mobile', categoryIDs?: Array<string>, logAssets: boolean, configOverride?: LH.Config, ignoreStatusCode?: boolean}} lrOpts Options coming from Lightrider
  * @return {Promise<string>}
  */
 async function runLighthouseInLR(connection, url, flags, lrOpts) {
-  const {lrDevice, categoryIDs, logAssets, configOverride} = lrOpts;
+  const {lrDevice, categoryIDs, logAssets, configOverride, ignoreStatusCode} = lrOpts;
 
   // Certain fixes need to kick in under LR, see https://github.com/GoogleChrome/lighthouse/issues/5839
   global.isLightrider = true;
@@ -96,8 +96,9 @@ async function runLighthouseInLR(connection, url, flags, lrOpts) {
     config = configOverride;
   } else {
     config = lrDevice === 'desktop' ? LR_PRESETS.desktop : LR_PRESETS.mobile;
+    config.settings = config.settings || {};
+    config.settings.ignoreStatusCode = ignoreStatusCode;
     if (categoryIDs) {
-      config.settings = config.settings || {};
       config.settings.onlyCategories = categoryIDs;
     }
   }

clients/test/lightrider/lightrider-entry-test.js

@@ -101,6 +101,19 @@ describe('lightrider-entry', () => {
       runStub.mockRestore();
     });
 
+    it('disables 404 with flag', async () => {
+      const runStub = jestMock.spyOn(Runner, 'gather');
+
+      const url = 'https://example.com';
+
+      const ignoreStatusCode = true;
+      await runLighthouseInLR(mockConnection, url, {}, {ignoreStatusCode});
+      const resolvedConfig = runStub.mock.calls[0][1].resolvedConfig;
+      assert.equal(resolvedConfig.settings.ignoreStatusCode, true);
+
+      runStub.mockRestore();
+    });
+
     it('overrides the default config when one is provided', async () => {
       const runStub = jestMock.spyOn(Runner, 'gather');
 

proto/lighthouse-result.proto

@@ -128,7 +128,7 @@ message LighthouseResult {
   map<string, CategoryGroup> category_groups = 11;
 
   // Message containing the configuration settings for the LH run
-  // Next ID: 10
+  // Next ID: 11
   message ConfigSettings {
     // The possible form factors an audit can be run in.
     // This enum served the emulated_form_factor field, but in v7, that field
@@ -203,6 +203,9 @@ message LighthouseResult {
 
     // Screen emulation properties (width, height, dpr, mobile viewport) to apply or an object of `{disabled: true}` if Lighthouse should avoid applying screen emulation. If either emulation is applied outside of Lighthouse, or it's being run on a mobile device, it typically should be set to disabled. For desktop, we recommend applying consistent desktop screen emulation.
     ScreenEmulation screen_emulation = 9;
+
+    // Indicating whether Lighthouse should ignore status codes.
+    bool ignore_status_code = 10;
   }
 
   // The settings that were used to run this audit