Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(lr): include flag for ignoring bad page status code #15764

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Conversation

adrianaixba
Copy link
Collaborator

@adrianaixba adrianaixba commented Jan 16, 2024

ref #10493

proto/lighthouse-result.proto Show resolved Hide resolved
@connorjclark connorjclark changed the title clients(lr): include flag for ignoring fatal errors clients(lr): include flag for ignoring bad page status code Jan 16, 2024
@benschwarz
Copy link
Contributor

Is it correct to assume that this change will make it possible to test a 404 page on PageSpeed?

@adrianaixba adrianaixba merged commit 629f5e7 into main Jan 16, 2024
29 checks passed
@adrianaixba adrianaixba deleted the lr-404 branch January 16, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants