Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(ci): fix deprecated node usage in checkout@v3 #16022

Conversation

hamirmahal
Copy link
Contributor

Summary

CI uses actions/checkout@v3, which uses a deprecated version of Node.js. This pull request updates that action to the latest version.

Related Issues/PRs

This pull request fixes #16021.

config-file: '.github/workflows/markdown.links.config.json'
folder-path: 'docs/'
- uses: actions/checkout@v3
use-quiet-mode: "yes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still work without the quotes/whitespace changes? If so can we reduce churn by just upgrading the v3 to v4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this still works without the formatting changes.

@adamraine adamraine merged commit c977fe8 into GoogleChrome:main May 28, 2024
24 checks passed
@hamirmahal hamirmahal deleted the fix/deprecated-node-usage-in-actions-checkout branch May 28, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI uses actions/checkout@v3, which uses a deprecated version of Node.js
3 participants