convert DoBetterWeb gatherers to new error system #1641
Conversation
updates DateNowUse, DocWriteUse, and ConsoleTimeUsage gatherers
| /** | ||
| * Returns WebSQL database information or null if none was found. | ||
| * @param {!Object} options | ||
| * @return {?{id: string, domain: string, name: string, version: string}} |
There was a problem hiding this comment.
this one also changed a bit. Before this was returning the object returned by the protocol (which has all information on a property named database) on the artifact on a property also named database, so to get e.g. the name you'd have to do artifacts.WebSQL.database.database.name. Now it's artifacts.WebSQL.name, and artifacts.WebSQL is null if no database was found.
I think part of this was a symptom of the -1 error system. It was easy to check |
| @@ -147,15 +147,14 @@ class TagsBlockingFirstPaint extends Gatherer { | |||
| return options.driver.evaluateScriptOnLoad(scriptSrc); | |||
| } | |||
|
|
|||
| /** | |||
| * @param {!Object} options | |||
| * @param {{networkRecords: !Array<!NetworkRecord>}} tracingData | |||
There was a problem hiding this comment.
{!{networkRecords: !Array<!NetworkRecord>}}?
There was a problem hiding this comment.
record types like this are non-nullable, so the ! is technically correct but unnecessary. It would have been really nice if everything had been non-nullable by default from the start :(
Yeah, good point. |
with #1624 this completes the transition of the gatherers to using actual errors instead of -1 artifacts :)
These are all pretty straightforward so I grouped them more coarsely by similar gatherers per commit.
The biggest change was I changed the artifact returned by the call site gatherers (
Date.now,document.write, etc) so instead of returning{usage: [/* locations of call sites */]}they just return[/* locations of call sites */]. If that's bad I can revert, but the indirection seems unnecessary now that we've lived with these for a while now.