convert DoBetterWeb gatherers to new error system

lighthouse-core/audits/dobetterweb/link-blocking-first-paint.js

@@ -49,12 +49,6 @@ class LinkBlockingFirstPaintAudit extends Audit {
    */
   static computeAuditResultForTags(artifacts, tagFilter) {
     const artifact = artifacts.TagsBlockingFirstPaint;
-    if (artifact.value === -1) {
-      return {
-        rawValue: -1,
-        debugString: artifact.debugString
-      };
-    }
 
     const filtered = artifact.filter(item => item.tag.tagName === tagFilter);
 

lighthouse-core/audits/dobetterweb/uses-optimized-images.js

@@ -81,10 +81,6 @@ class UsesOptimizedImages extends Audit {
   static audit_(artifacts, networkThroughput) {
     const images = artifacts.OptimizedImages;
 
-    if (images.rawValue === -1) {
-      return UsesOptimizedImages.generateAuditResult(images);
-    }
-
     const failedImages = [];
     let totalWastedBytes = 0;
     let hasAllEfficientImages = true;

lighthouse-core/gather/gatherers/dobetterweb/optimized-images.js

@@ -114,6 +114,11 @@ class OptimizedImages extends Gatherer {
     });
   }
 
+  /**
+   * @param {!Object} options
+   * @param {{networkRecords: !Array<!NetworRecord>}} traceData
+   * @return {!Promise<!Array<!Object>}
+   */
   afterPass(options, traceData) {
     const networkRecords = traceData.networkRecords;
     const imageRecords = OptimizedImages.filterImageRequests(options.url, networkRecords);
@@ -131,8 +136,6 @@ class OptimizedImages extends Gatherer {
       }
 
       return results;
-    }).catch(err => {
-      return {rawValue: -1, debugString: err};
     });
   }
 }

lighthouse-core/gather/gatherers/dobetterweb/tags-blocking-first-paint.js

@@ -147,15 +147,14 @@ class TagsBlockingFirstPaint extends Gatherer {
     return options.driver.evaluateScriptOnLoad(scriptSrc);
   }
 
+  /**
+   * @param {!Object} options
+   * @param {{networkRecords: !Array<!NetworkRecord>}} tracingData
+   * @return {!Array<{tag: string, transferSize: number, startTime: number, endTime: number}>}
+   */
   afterPass(options, tracingData) {
     return TagsBlockingFirstPaint
-      .findBlockingTags(options.driver, tracingData.networkRecords)
-      .catch(err => {
-        return {
-          value: -1,
-          debugString: err.message
-        };
-      });
+      .findBlockingTags(options.driver, tracingData.networkRecords);
   }
 }
 

lighthouse-core/test/audits/dobetterweb/link-blocking-first-paint-test.js

@@ -22,18 +22,6 @@ const assert = require('assert');
 /* eslint-env mocha */
 
 describe('Link Block First Paint audit', () => {
-  it('fails when error input present', () => {
-    const debugString = 'the uniquest debug string';
-    const auditResult = LinkBlockingFirstPaintAudit.audit({
-      TagsBlockingFirstPaint: {
-        value: -1,
-        debugString
-      }
-    });
-    assert.equal(auditResult.rawValue, -1);
-    assert.strictEqual(auditResult.debugString, debugString);
-  });
-
   it('fails when there are links found which block first paint', () => {
     const linkDetails = {
       tagName: 'LINK',

lighthouse-core/test/audits/dobetterweb/script-blocking-first-paint-test.js

@@ -22,18 +22,6 @@ const assert = require('assert');
 /* eslint-env mocha */
 
 describe('Script Block First Paint audit', () => {
-  it('fails when error input present', () => {
-    const debugString = 'first paint debug string';
-    const auditResult = ScriptBlockingFirstPaintAudit.audit({
-      TagsBlockingFirstPaint: {
-        value: -1,
-        debugString
-      }
-    });
-    assert.equal(auditResult.rawValue, -1);
-    assert.strictEqual(auditResult.debugString, debugString);
-  });
-
   it('fails when there are scripts found which block first paint', () => {
     const scriptDetails = {
       tagName: 'SCRIPT',

lighthouse-core/test/audits/dobetterweb/uses-optimized-images-test.js

@@ -37,18 +37,6 @@ function generateImage(type, originalSize, webpSize, jpegSize) {
 /* eslint-env mocha */
 
 describe('Page uses optimized images', () => {
-  it('fails when gatherer returns error', () => {
-    const debugString = 'All image optimizations failed.';
-    const auditResult = UsesOptimizedImagesAudit.audit_({
-      OptimizedImages: {
-        rawValue: -1,
-        debugString: debugString
-      },
-    });
-    assert.equal(auditResult.rawValue, -1);
-    assert.equal(auditResult.debugString, debugString);
-  });
-
   it('fails when one jpeg image is unoptimized', () => {
     const auditResult = UsesOptimizedImagesAudit.audit_({
       OptimizedImages: [

lighthouse-core/test/gather/gatherers/dobetterweb/optimized-images-test.js

@@ -126,12 +126,4 @@ describe('Optimized images', () => {
       assert.ok(/whoops/.test(failed.err.message), 'passed along error message');
     });
   });
-
-  it('handles total driver failure', () => {
-    options.driver.evaluateAsync = () => Promise.reject(new Error('fatal'));
-    return optimizedImages.afterPass(options, traceData).then(artifact => {
-      assert.equal(artifact.rawValue, -1);
-      assert.ok(artifact.debugString);
-    });
-  });
 });

lighthouse-core/test/gather/gatherers/dobetterweb/tags-blocking-first-paint-test.js

@@ -155,17 +155,4 @@ describe('First paint blocking tags', () => {
       assert.deepEqual(artifact, expected);
     });
   });
-
-  it('handles driver failure', () => {
-    return tagsBlockingFirstPaint.afterPass({
-      driver: {
-        evaluateAsync() {
-          return Promise.reject(new Error('such a fail'));
-        }
-      }
-    }, traceData).then(artifact => {
-      assert.equal(artifact.value, -1);
-      assert.ok(artifact.debugString);
-    });
-  });
 });