Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report: fix table overflow with Firefox. #1704

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Report: fix table overflow with Firefox. #1704

merged 1 commit into from
Feb 13, 2017

Conversation

XhmikosR
Copy link
Contributor

before
2017-02-12_14-56-58

after
2017-02-12_14-57-18

@@ -33,6 +33,7 @@
font-family: monospace;
display: block;
margin: 0;
overflow-y: hidden;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overflow-x: auto. Tells the pre what to do (instead of telling it what not to do).
Would make me less nervous with tables, pre wrapping, and different browser compat in the mix. Clearly the latter is already an issue for FF.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Changed it.

@paulirish paulirish merged commit 6d5d4fe into GoogleChrome:master Feb 13, 2017
@XhmikosR XhmikosR deleted the report-table-ff-overflow branch February 13, 2017 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants