Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to PWA Checklist #1734

Merged
merged 4 commits into from
Feb 17, 2017
Merged

Link to PWA Checklist #1734

merged 4 commits into from
Feb 17, 2017

Conversation

sendilkumarn
Copy link
Contributor

fixes #1638

@@ -106,6 +106,7 @@
"description": "These audits validate the aspects of a Progressive Web App.",
Copy link
Contributor

@ebidel ebidel Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptions support markdown. I'd prefer we just add a link here in the aggregation description rather than pipe a new property throughout the codebase. We already have a few existing places like extendedInfo and description text for help text like this. IMO, it's also better to have this at the top of the section rather than the bottom. It'll get missed down there.

"description": "These audits validate the aspects of a Progressive Web App. They're a subset of the [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist)."

removed the extra variable and added it to description

correction
@sendilkumarn
Copy link
Contributor Author

sendilkumarn commented Feb 16, 2017

@ebidel 👍 It is added.

@@ -447,7 +447,7 @@
"aggregations": [
{
"name": "Progressive Web App",
"description": "These audits validate the aspects of a Progressive Web App.",
"description": "These audits validate the aspects of a Progressive Web App. They are a subset of the [PWA Checklist.](https://developers.google.com/web/progressive-web-apps/checklist)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you stick the periods outside of the [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nit I know :)

@paulirish
Copy link
Member

fixed the nit. ;)
why do we need to change the handlebars loop?

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@sendilkumarn
Copy link
Contributor Author

@paulirish Thanks. :)
That's my mistake, forgot to remove it. Sorry.

@paulirish paulirish merged commit c031ecf into GoogleChrome:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to PWA Checklist at end of PWA section in report
4 participants