feat(cli): add support for custom trace categories #1866
Conversation
patrickhulce
changed the title
lighthouse-core/gather/driver.js
Outdated
| */ | ||
| beginTrace(flags) { | ||
| const additionalCategories = flags && flags.traceCategories && flags.traceCategories.split(','); | ||
| const traceCategories = new Set(this._traceCategories.concat(additionalCategories || [])); |
There was a problem hiding this comment.
i kinda prefer moving this || [] to the above statement, so we can rely on it as an array.
There was a problem hiding this comment.
let's just drop in const _uniq = arr => Array.from(new Set(arr)); and use it so we're not tossing this type from Set back to array a few lines later.
lighthouse-cli/bin.ts
Outdated
| @@ -78,6 +79,7 @@ const cliFlags = yargs | |||
| 'save-artifacts': 'Save all gathered artifacts to disk', | |||
| 'list-all-audits': 'Prints a list of all available audits and exits', | |||
| 'list-trace-categories': 'Prints a list of all required trace categories and exits', | |||
| 'trace-categories': 'Additional categories to capture with the trace (comma-delimited).', | |||
There was a problem hiding this comment.
how about addl-trace-categories ? to clarify that this doesn't overwrite the defaults
There was a problem hiding this comment.
additional- but done :)
patrickhulce
force-pushed
the
custom_trace
branch
from
ec3ad94
to
fa2bd36
Compare
| /** | ||
| * @param {{additionalTraceCategories: string=}=} flags | ||
| */ | ||
| beginTrace(flags) { |
There was a problem hiding this comment.
nit: could use some fancy default params: flags = {additionalTraceCategories: ''}
then: const additionalCategories = flags.additionalTraceCategories.split(',').filter(String);
There was a problem hiding this comment.
true, but would still need the additionalTraceCategories check so just gets rid of flags && in favor of = {additionalTraceCategories: ''} gotta save those bytes you know ;)
fixes #1663