Remove images from critical request chains. #2085
Conversation
|
Thanks for the contribution! You should have a look at the smokehouse test as they are failing. If you need help just give a shout. |
abacon
force-pushed
the
images-not-critical
branch
from
b542d06
to
9fc8afa
Compare
|
Hi @wardpeet! Thanks so much for your patience with this. I've modified the tests so that they pass, but would you mind checking to make sure that I'm not creating any gaps in coverage? |
| @@ -38,6 +38,10 @@ class CriticalRequestChains extends ComputedArtifact { | |||
| if (resourceTypeCategory === WebInspector.resourceTypes.XHR._category) { | |||
| return false; | |||
| } | |||
| // Images are also non-critical. | |||
| if (resourceTypeCategory === WebInspector.resourceTypes.Image._category) { | |||
There was a problem hiding this comment.
I wonder if it would be cleaner to do an array of resourceTypes that are non-critical and check includes on it similar to request priority
There was a problem hiding this comment.
good idea. let's do that @abacon
There was a problem hiding this comment.
@abacon can you do this in a followup PR?
I'll land this now.
There was a problem hiding this comment.
Yeah, no problem! Thanks for merging. 😍💖💪
There was a problem hiding this comment.
Nah it's all good! Thanks so much @stramel :)
| @@ -38,6 +38,10 @@ class CriticalRequestChains extends ComputedArtifact { | |||
| if (resourceTypeCategory === WebInspector.resourceTypes.XHR._category) { | |||
| return false; | |||
| } | |||
| // Images are also non-critical. | |||
| if (resourceTypeCategory === WebInspector.resourceTypes.Image._category) { | |||
There was a problem hiding this comment.
@abacon can you do this in a followup PR?
I'll land this now.
Fixes #1550. Hope this is still useful!