-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split optimized images into WebP and optimize audit #2216
Conversation
This makes sense to me. I think we should keep the audits in "Opportunities" (not move them to Diagnostics) as they are potential improvements to be made. One thing, can you group the 3 image audits together, probably in this order:
"Convert images to WebP" could also be "Serve images as WebP" to suggest that this would be in addition to serving other formats. But that would also address Kayce's concerns in the bug. |
Needs a rebase. |
also turns out we've been hiding |
@ebidel PTAL rebased and updated order :) |
I'm really happy with this split. Good call. I like the title of both of these audits now. seems good. |
closes #2044 and does some drive by cleanup of byte efficiency audits
Splits the audit to track two concerns separately:
JPEG doesn't have an insane amount of metadata or is too high quality, can be expanded to do the equivalent of PNG crush too.
Currently just a WebP check but could be fancier for your PNG could actually be a JPEG, etc.
Also reduces the aggressiveness of both of these by increasing the quality to 85 and increasing the ignore threshold to 4KB for JPEG and 8KB for WebP.
Questions:
Should the WebP check be moved down into diagnostics?Noscreenshot: (added by paul)