refactor(trace-of-tab): return timestamps in microseconds #2454
Conversation
|
meta comment: where should we document this? It's good to know (and important to know when you do anything with these :) Probably trace-of-tab, but maybe also in https://github.com/GoogleChrome/lighthouse/blob/master/docs/architecture.md? |
| timestamps[metric] = metrics[metric] && metrics[metric].ts / 1000; | ||
| timings[metric] = timestamps[metric] - timestamps.navigationStart; | ||
| timestamps[metric] = metrics[metric] && metrics[metric].ts; | ||
| timings[metric] = (timestamps[metric] - navigationStart.ts) / 1000; |
There was a problem hiding this comment.
I do wish we had a better name for these than timings, but may be too late :)
There was a problem hiding this comment.
ha a battle for another day :)
| @@ -54,7 +54,7 @@ class ConsistentlyInteractiveMetric extends Audit { | |||
| * @return {!Array<!TimePeriod>} | |||
| */ | |||
| static _findNetworkQuietPeriods(networkRecords, traceOfTab) { | |||
| const traceEnd = traceOfTab.timestamps.traceEnd; | |||
| const traceEndTsInMs = traceOfTab.timestamps.traceEnd / 1000; | |||
There was a problem hiding this comment.
nit: move this down to where it's used?
There was a problem hiding this comment.
aw I liked that each function in this file got this aliasing out of the way at the beginning :(
did it make you look for its use too much right afterwards?
There was a problem hiding this comment.
ha, yeah, exactly. I figured that's what this was doing, but then my next thought was, "wait, what is this even used for?"
|
got another PR comin' with some more groovy docs 📜 📝 |
fixes #2116