docs: add trace interpretation guide #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
reviewed
Jun 8, 2017
docs/architecture.md
Outdated
|
|
||
| ### Trace of Tab | ||
|
|
||
| Trace of tab identifies trace events for key moments (navigation start, first meaningful paint, DOM content loaded, trace end, etc) and provides filtered views of just the main process and the main thread events. Because the timestamps are not interesting in isolation, trace of tab also calculates the times in milliseconds of key moments relative to navigation start, thus providing the typical interpretation of first meaningful paint in ms. |
There was a problem hiding this comment.
- link to trace-of-tab?
- "Because the timestamps are not necessarily interesting in isolation..." :)
- give the
timestampsandtimingsnames for each of the two groups of times?
docs/architecture.md
Outdated
|
|
||
| ### Tracing Processor | ||
|
|
||
| Tracing processor takes the output of trace of tab and identifies the toplevel main thread tasks, their durations, and corresponding impact on page responsiveness. Tracing process also translates task timestamps to milliseconds since navigation start for easier interpretation in computed gatherers and audits. |
There was a problem hiding this comment.
- top-level
- "Tracing processor also translates..."
docs/architecture.md
Outdated
|
|
||
| ### Trace of Tab | ||
|
|
||
| Trace of tab identifies trace events for key moments (navigation start, first meaningful paint, DOM content loaded, trace end, etc) and provides filtered views of just the main process and the main thread events. Because the timestamps are not interesting in isolation, trace of tab also calculates the times in milliseconds of key moments relative to navigation start, thus providing the typical interpretation of first meaningful paint in ms. |
There was a problem hiding this comment.
hyphenate or camelCase trace-of-tab? It feels weird without articles, so clearly a proper name, but also lower case and without anything connecting the words :)
brendankenny
approved these changes
Jun 14, 2017
There was a problem hiding this comment.
sorry, meant to LGTM this.
@paulirish might want to take a look now that he's back, but could also just add in a followup if he wants more stuff
|
followup suggestions welcome @paulirish :) |
|
All good! This looks A+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #2454