Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link remaining a11y audits to aXe docs #2709

Merged
merged 3 commits into from
Jul 20, 2017
Merged

link remaining a11y audits to aXe docs #2709

merged 3 commits into from
Jul 20, 2017

Conversation

kaycebasques
Copy link
Contributor

The current plan is to link all of the a11y audits to their respective sources in the aXe docs.

These audits currently link to references I wrote before the a11y category ballooned to 50+ audits.

Deprecating the a11y docs I wrote reduces my workload while also ensuring a consistent UX (if you click on "Learn more" in an a11y doc now, you can always expect to land on an aXe doc)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robdodson said he was good with this change.

The few docs pages I checked don't appear to be different, but should we be linking to https://dequeuniversity.com/rules/axe/2.2/* instead of 1.1 since 2.2.1 is the version of axe-core we're now using?

@paulirish
Copy link
Member

@kaycebasques i gave you a PR for that small change: https://github.com/kaycebasques/lighthouse/pull/1

looks like i can't update your fork directly so.. :) wanna merge my PR?

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@kaycebasques
Copy link
Contributor Author

@paulirish done

@paulirish paulirish merged commit 924e1f1 into GoogleChrome:master Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants