Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(chrome-launcher): Upgrade chrome-launcher #4192

Merged
merged 2 commits into from
Jan 9, 2018

Conversation

wardpeet
Copy link
Collaborator

@wardpeet wardpeet commented Jan 6, 2018

Upgrade chrome-launcher to 0.10.1.

I wasn't sure why chrome-launcher does not have a ^ in package.json so feel free to decline this PR.

@patrickhulce
Copy link
Collaborator

uh-oh looks like we broke chrome-launcher typings :(

image

@paulirish
Copy link
Member

ruh roh. looks like i did indeed break the TS typings with the folder move: GoogleChrome/chrome-launcher#69 (comment)

@paulirish
Copy link
Member

just rebased to get the #4209 fix that was breaking this PR.

why was it breaking this PR out of the blue? that, we'll never know. 🐩

@samccone
Copy link
Contributor

samccone commented Jan 9, 2018

Is there a test we could add to chrome-launcher to prevent this?

@paulirish
Copy link
Member

Is there a test we could add to chrome-launcher to prevent this?

yes i would love that. not how to write it, personally. you might know better than most of us. :)

@wardpeet
Copy link
Collaborator Author

wardpeet commented Jan 9, 2018

Not 100% sure but we can write a test like this:

npm pack
Unpack zip 
Parse package.json
See if typing field exists

By default it checks in the root directory

@paulirish
Copy link
Member

paulirish commented Jan 9, 2018

i was thinking a more functional test. e.g. some module that require()s chrome-launcher successfully typechecks with TS.

filed as GoogleChrome/chrome-launcher#83

@paulirish
Copy link
Member

even though travis is busted, appveyor is happy. shipping.

@paulirish paulirish merged commit 6c5e7a4 into master Jan 9, 2018
@paulirish paulirish deleted the deps/update-chrome-launcher branch January 9, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants