-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add web app manifest parsing gatherer #48
Conversation
} | ||
|
||
// TODO(bckenny): validate color, but for reals | ||
// possibly pull in devtools/front_end/common/Color.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as stated here, planning on bringing in e.g. devtools frontend color parsing code rather than dragging in all of jsdom just to do some color parsing code
} | ||
|
||
var JSGatherer = { | ||
run: function(driver, url) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in theory this gatherer could collect all the functions that need to run in the context of the page itself (e.g. the one in viewport-meta-tag/gather.js), but long term (as we think about extensibility) it may be too hard to guarantee that these scripts don't step on each other
@@ -0,0 +1,329 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move from helpers => parsers
I can see the need in the future for multiple parsers
@paullewis
_logs
is dropped in favor of the warning being associated with the erroneous manifest entry..value
to get the parsed value of that node. Kind of annoying, open to ideas there. See changes to test for example.data.parsedManifest
inside your friendly neighborhood auditor