Extension backport #49
Conversation
…into extension-backport
| var flattenedAudits = results.reduce(function(prev, curr) { | ||
| class Auditor { | ||
|
|
||
| flattenArtifacts_(artifacts) { |
There was a problem hiding this comment.
lets _ prefix this just to mark it as "private"
There was a problem hiding this comment.
https://google.github.io/styleguide/javascriptguide.xml#Visibility__private_and_protected_fields_ indicates that private and protected are suffixed not prefixed :-/
There was a problem hiding this comment.
let's do something at least
| const manifest = manifestParser(inputs.manifest).value; | ||
|
|
||
| if (manifest && manifest.icons) { | ||
| const icons192 = manifest.icons.raw.find(function(i) { |
There was a problem hiding this comment.
nit i => e.sizes === '192x192'
| "manifest_version": 2, | ||
| "description": "__MSG_appDescription__", |
There was a problem hiding this comment.
this was for internationalization which we might want to continue using :)
There was a problem hiding this comment.
Did not know. Will fix.
Extension backport and refactor.
|
Closes #48 - @brendankenny I folded you work into what I was doing, as discussed. |
| var flattenedAudits = results.reduce(function(prev, curr) { | ||
| class Auditor { | ||
|
|
||
| _flattenArtifacts(artifacts) { |
There was a problem hiding this comment.
ha, I didn't mean to state that so strongly. More like they can be static since they aren't keeping track of state or anything
There was a problem hiding this comment.
It's fine. I changed it.
| const manifest = manifestParser(inputs.manifest).value; | ||
|
|
||
| if (manifest) { | ||
| hasName = (!!manifest.name); |
Builds on @brendankenny's patch; does a total refactor of many things.
But now.... 🌟 The extension and node versions share the same audits! 🌟
🎉