Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension backport #49

Merged
merged 15 commits into from
Mar 22, 2016
Merged

Extension backport #49

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2230f6a
intial commit of manifest-parser as helper
brendankenny Mar 21, 2016
0382fe3
update manifest-parser tests to use expect
brendankenny Mar 21, 2016
988edff
manifest-parser eslint fixes
brendankenny Mar 21, 2016
eea93d2
update manifest parser to return more detailed parsing information
brendankenny Mar 22, 2016
f5d7e5c
add manifest parsing to gather stage
brendankenny Mar 22, 2016
19edfe4
add js-in-context gatherer
brendankenny Mar 22, 2016
432323b
array-ify icon sizes Set
brendankenny Mar 22, 2016
ead5a75
Merge branch 'manifest' of https://github.com/brendankenny/lighthouse…
paullewis Mar 22, 2016
3f4a5f2
Backports extension; refactors much.
paullewis Mar 22, 2016
c1a4c2d
Removes tmp old driver file.
paullewis Mar 22, 2016
7c2ce06
Style nits. Removes unnecessary gather.
paullewis Mar 22, 2016
efa41a8
Removes log.
paullewis Mar 22, 2016
ee00670
Updates the manifest for tidiness.
paullewis Mar 22, 2016
06166c3
Adds URL gatherer.
paullewis Mar 22, 2016
8b05475
Fixes PageAgent global for network recorder.
paullewis Mar 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions extension/app/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "__MSG_appName__",
"version": "0.0.3",
"name": "Lighthouse",
"version": "0.0.5",
"manifest_version": 2,
"description": "__MSG_appDescription__",
"description": "Helping you avoid Progressive Web App woes.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was for internationalization which we might want to continue using :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not know. Will fix.

"icons": {
"16": "images/icon-16.png",
"128": "images/icon-128.png"
Expand All @@ -22,7 +22,7 @@
"default_icon": {
"38": "images/icon-38.png"
},
"default_title": "lighthouse",
"default_title": "Lighthouse",
"default_popup": "popup.html"
}
}