Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(viewer): load *.json if no *.lighthouse.report.json #5343

Merged
merged 2 commits into from
May 24, 2018
Merged

misc(viewer): load *.json if no *.lighthouse.report.json #5343

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3be79ec
viewer: consider loading *.json files
paulirish May 24, 2018
f72cb84
mmmmmm
paulirish May 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lighthouse-viewer/app/src/github-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,11 @@ class GithubApi {
const etag = resp.headers.get('ETag');
return resp.json().then(json => {
// Attempt to use first file in gist with report extension.
const filename = Object.keys(json.files)
let filename = Object.keys(json.files)
.find(filename => filename.endsWith(GithubApi.LH_JSON_EXT));
if (!filename) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Otherwise, fall back to first json file in gist or something to follow up to previous comment?

filename = Object.keys(json.files).find(filename => filename.endsWith('.json'));
}
if (!filename) {
throw new Error(
`Failed to find a Lighthouse report (*${GithubApi.LH_JSON_EXT}) in gist ${id}`
Expand Down