core: adjust audit titles for consistency #5717
Conversation
| @@ -15,7 +15,7 @@ class CriticalRequestChains extends Audit { | |||
| static get meta() { | |||
| return { | |||
| id: 'critical-request-chains', | |||
| title: 'Critical Request Chains', | |||
| title: 'Minimize Critical Request Chains', | |||
There was a problem hiding this comment.
the audit is marked notApplicable if no requests are made, so everyone who gets the title could in theory minimize their chains. There might not be any benefit to doing that, but that's just a fundamental issue with the audit that needs to be addressed elsewhere :)
|
@patrickhulce sorry, this will conflict with #5716, but at least it's small |
that's fine. It should be easy |
There was a problem hiding this comment.
optimizations only have failure titles (defined in .title). This leads to a big inconsistency when looking at all passed audits and their phrasing.
but we're not fixing that today.
Let's revisit phrasing later. PSI's approach (always failure title, customized description) is compelling.
| @@ -244,7 +244,7 @@ | |||
| }, | |||
| "time-to-first-byte": { | |||
| "id": "time-to-first-byte", | |||
| "title": "Keep server response times low (TTFB)", | |||
| "title": "Server response times are short (TTFB)", | |||
There was a problem hiding this comment.
👀 TTFB is one for the non-translated strings / glossary.
brendankenny
force-pushed
the
titletweaks
branch
from
a9d4759
to
e7393b1
Compare
|
updated to live on top of the newly extracted UIStrings |
| @@ -204,7 +204,10 @@ | |||
| "message": "Redirects introduce additional delays before the page can be loaded. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/redirects)." | |||
| }, | |||
| "lighthouse-core/audits/time-to-first-byte.js | title": { | |||
| "message": "Keep server response times low (TTFB)" | |||
| "message": "Server response times are short (TTFB)" | |||
| @@ -46,6 +46,6 @@ if [ $retVal -eq 0 ]; then | |||
| colorText "✅ PASS. No change in LHR." "$green" | |||
| else | |||
| colorText "❌ FAIL. LHR has changed." "$red" | |||
| echo "Run \`yarn update:sample-json\` to rebaseline the golden LHR." | |||
| echo "Run \`yarn i18n:collect-strings\` and \`yarn update:sample-json\` to rebaseline the golden LHR." | |||
There was a problem hiding this comment.
It's definitely confusing to update strings in audits but get no changes when you run yarn update:sample-json . This still isn't the best place for this advice (though it is needed) as there's no change to sample_v2.json until you extract the strings, so this test was actually passing (though yarn i18n:checks would fail on travis).
Should we add i18n:checks to diff:sample-json so the check does both? Or add i18n:collect-strings to update:sample-json so it's automatically done at the same time?
from lightsights discussions. Let the bikeshedding commence!