Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension: tweak runLighthouseAsInCLI jsdoc #5812

Merged
merged 1 commit into from
Aug 9, 2018
Merged

extension: tweak runLighthouseAsInCLI jsdoc #5812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lighthouse-extension/app/src/lighthouse-ext-background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ async function runLighthouseInExtension(flags, categoryIDs) {
* Run lighthouse for connection and provide similar results as in CLI.
* @param {Connection} connection
* @param {string} url
* @param {LH.Flags} flags Lighthouse flags plus logAssets
Specify outputFormat to change the output format.
* @param {LH.Flags} flags Lighthouse flags, including `output`
* @param {Array<string>} categoryIDs Name values of categories to include.
* @param {{logAssets: boolean}} lrOpts Options coming from Lightrider
* @return {Promise<string|Array<string>|void>}
Expand Down