Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove no-websql audit #6293

Merged
merged 4 commits into from
Oct 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,6 @@ Object {
Object {
"path": "dobetterweb/js-libraries",
},
Object {
"path": "dobetterweb/no-websql",
},
Object {
"path": "dobetterweb/notification-on-start",
},
Expand Down Expand Up @@ -594,10 +591,6 @@ Object {
"id": "appcache-manifest",
"weight": 1,
},
Object {
"id": "no-websql",
"weight": 1,
},
Object {
"id": "is-on-https",
"weight": 1,
Expand Down Expand Up @@ -1077,9 +1070,6 @@ Object {
Object {
"path": "dobetterweb/tags-blocking-first-paint",
},
Object {
"path": "dobetterweb/websql",
},
Object {
"path": "seo/meta-description",
},
Expand Down
8 changes: 0 additions & 8 deletions lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,6 @@ <h2>Do better web tester page</h2>
document.write('2.0!'); // FAIL
}

function websqlTest() {
const db = openDatabase('mydb', '1.0', 'my first database', 1024);
}

function passiveEventsListenerTest() {
// FAIL or PASS - field trial for document level defaulting to passive M71+
window.addEventListener('wheel', function(e) {
Expand Down Expand Up @@ -325,7 +321,6 @@ <h2>Do better web tester page</h2>
documentWriteTest();
dateNowTest();
consoleTimeTest();
websqlTest();
passiveEventsListenerTest();
geolocationOnStartTest();
notificationOnStartTest();
Expand All @@ -345,9 +340,6 @@ <h2>Do better web tester page</h2>
if (params.has('consoleTime')) {
consoleTimeTest();
}
if (params.has('websql')) {
websqlTest();
}
if (params.has('passiveEvents')) {
passiveEventsListenerTest();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ module.exports = [
},
},
},
'no-websql': {
score: 0,
displayValue: 'Found "mydb" (v1.0)',
},
'notification-on-start': {
score: 0,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ module.exports = [
'no-document-write': {
score: 1,
},
'no-websql': {
score: 1,
},
'uses-passive-event-listeners': {
score: 1,
},
Expand Down
47 changes: 0 additions & 47 deletions lighthouse-core/audits/dobetterweb/no-websql.js

This file was deleted.

3 changes: 0 additions & 3 deletions lighthouse-core/config/default-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ const defaultConfig = {
'dobetterweb/password-inputs-with-prevented-paste',
'dobetterweb/response-compression',
'dobetterweb/tags-blocking-first-paint',
'dobetterweb/websql',
'seo/meta-description',
'seo/font-size',
'seo/crawlable-links',
Expand Down Expand Up @@ -197,7 +196,6 @@ const defaultConfig = {
'dobetterweb/no-document-write',
'dobetterweb/no-vulnerable-libraries',
'dobetterweb/js-libraries',
'dobetterweb/no-websql',
'dobetterweb/notification-on-start',
'dobetterweb/password-inputs-can-be-pasted-into',
'dobetterweb/uses-http2',
Expand Down Expand Up @@ -399,7 +397,6 @@ const defaultConfig = {
title: 'Best Practices',
auditRefs: [
{id: 'appcache-manifest', weight: 1},
{id: 'no-websql', weight: 1},
{id: 'is-on-https', weight: 1},
{id: 'uses-http2', weight: 1},
{id: 'uses-passive-event-listeners', weight: 1},
Expand Down
52 changes: 0 additions & 52 deletions lighthouse-core/gather/gatherers/dobetterweb/websql.js

This file was deleted.

33 changes: 0 additions & 33 deletions lighthouse-core/test/audits/dobetterweb/no-websql-test.js

This file was deleted.

13 changes: 0 additions & 13 deletions lighthouse-core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -2402,15 +2402,6 @@
"summary": {}
}
},
"no-websql": {
"id": "no-websql",
"title": "Uses WebSQL DB",
"description": "Web SQL is deprecated. Consider using IndexedDB instead. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/web-sql).",
"score": 0,
"scoreDisplayMode": "binary",
"rawValue": false,
"displayValue": "Found \"mydb\" (v1.0)"
},
"notification-on-start": {
"id": "notification-on-start",
"title": "Requests the notification permission on page load",
Expand Down Expand Up @@ -3233,10 +3224,6 @@
"id": "appcache-manifest",
"weight": 1
},
{
"id": "no-websql",
"weight": 1
},
{
"id": "is-on-https",
"weight": 1
Expand Down
12 changes: 0 additions & 12 deletions proto/sample_v2_round_trip.json
Original file line number Diff line number Diff line change
Expand Up @@ -1602,14 +1602,6 @@
"scoreDisplayMode": "binary",
"title": "Includes front-end JavaScript libraries with known security vulnerabilities"
},
"no-websql": {
"description": "Web SQL is deprecated. Consider using IndexedDB instead. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/web-sql).",
"displayValue": "Found \"mydb\" (v1.0)",
"id": "no-websql",
"score": 0.0,
"scoreDisplayMode": "binary",
"title": "Uses WebSQL DB"
},
"notification-on-start": {
"description": "Users are mistrustful of or confused by sites that request to send notifications without context. Consider tying the request to user gestures instead. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/notifications-on-load).",
"details": {
Expand Down Expand Up @@ -2820,10 +2812,6 @@
"id": "appcache-manifest",
"weight": 1.0
},
{
"id": "no-websql",
"weight": 1.0
},
{
"id": "is-on-https",
"weight": 1.0
Expand Down
2 changes: 0 additions & 2 deletions typings/artifacts.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@ declare global {
Viewport: string|null;
/** The dimensions and devicePixelRatio of the loaded viewport. */
ViewportDimensions: Artifacts.ViewportDimensions;
/** WebSQL database information for the page or null if none was found. */
WebSQL: Crdp.Database.Database | null;
}

module Artifacts {
Expand Down