-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0.0-alpha.0 #6434
4.0.0-alpha.0 #6434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff.
only minor changelog formatting nits.
changelog.md
Outdated
|
||
## Readme | ||
|
||
* Remove "sh" format for CLI --help output ([#6311](https://github.com/googlechrome/lighthouse/pull/6311)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move into docs
changelog.md
Outdated
|
||
## Misc | ||
|
||
* proto: made default LighthouseError enum 'UNDEFINED' ([#6334](https://github.com/googlechrome/lighthouse/pull/6334)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move below with the proto block
changelog.md
Outdated
* only allow 1 error from each audit/gatherer ([#6215](https://github.com/googlechrome/lighthouse/pull/6215)) | ||
* Revert "core(driver): stringify protocol error messages (#6302)" ([#6328](https://github.com/googlechrome/lighthouse/pull/6328)) | ||
* fix typo in feature request template ([#6431](https://github.com/googlechrome/lighthouse/pull/6431)) | ||
* tests: run node 10 on Travis ([#6361](https://github.com/googlechrome/lighthouse/pull/6361)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can move to be in Tests
changelog.md
Outdated
* proto: reduce configSettings in proto to minimum ([88b2829](https://github.com/googlechrome/lighthouse/commit/88b2829)) | ||
* yarn: update lockfile for micromatch ([#6384](https://github.com/googlechrome/lighthouse/pull/6384)) | ||
|
||
## New Contributors! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw this at the top! \o/
very very nice.
changelog.md
Outdated
|
||
* offline-start-url ([#6397](https://github.com/googlechrome/lighthouse/pull/6397)) | ||
|
||
## CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ive been ordering these sections with most important first.. so probably.. Core, Report, then errthing else.
changelog.md
Outdated
* add primer on viewing the timing data ([#6393](https://github.com/googlechrome/lighthouse/pull/6393)) | ||
* typo fix ([#6335](https://github.com/googlechrome/lighthouse/pull/6335)) | ||
|
||
## Extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can merge this and Clients now. yay
changelog.md
Outdated
|
||
## CLI | ||
|
||
* docs: update docs for --output-path re: multiple output types ([#6339](https://github.com/googlechrome/lighthouse/pull/6339)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well toss into Docs section
@@ -1,3 +1,144 @@ | |||
<a name="4.0.0-alpha.0"></a> | |||
# 4.0.0-alpha.0 (2018-10-31) | |||
[Full Changelog](https://github.com/googlechrome/lighthouse/compare/v3.2.0...v4.0.0-alpha.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shipped 3.2.1 from a branch, so the compare wont work against it, but w/e.
technically these two commits aren't new to this rls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just leave it as 3.2.0 ? with or without noting the technicality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's totally fine to ignore the technicality and leave as 3.2.0. If someone's very meticulous record keeping is thrown off, we'll just take the heat :)
@@ -70,6 +70,8 @@ echo "Test the lighthouse-viewer build" | |||
# Start a server in dist/viewer/ and open the page in a tab. You should see the viewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you can remove this line and move 73/74 up here.
good hack with using static-server for this. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed it was necessary ... I tried python -m SimpleHTTPServer
first but I interpreted the viewer2x 400 error by thinking I need to use the static-server.
wdyt of instead suggesting cd dist/viewer ; python -m SimpleHTTPServer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wfm!
clients/extension/manifest.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "__MSG_appName__", | |||
"version": "3.2.0", | |||
"version": "3.3.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: i'd go with 3.3.0.4000 in case we have more alphas betas and we want to do 4001, etc
changelog.md
Outdated
|
||
Thanks to @CodeDem for improving how the image-aspect-ratio audit handles small images! | ||
|
||
Huge thanks to myself (@Hoten) for joining Lighthouse! Go me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
|
||
Thanks to @CodeDem for improving how the image-aspect-ratio audit handles small images! | ||
|
||
Huge thanks to myself (@Hoten) for joining Lighthouse! Go me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣
|
||
Thanks to @CodeDem for improving how the image-aspect-ratio audit handles small images! | ||
|
||
Huge thanks to myself (@Hoten) for joining Lighthouse! Go me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back in my day we just let @paulirish release, and he never mentioned if you even existed. 👀
Travis is failing, not sure why. EDIT: Paul ran it again. Worked this time. |
bump!