4.0.0-alpha.0 #6434

connorjclark · 2018-10-31T17:16:48Z

bump!

paulirish

great stuff.
only minor changelog formatting nits.

paulirish · 2018-10-31T17:32:36Z

changelog.md

+
+## Readme
+
+* Remove "sh" format for CLI --help output ([#6311](https://github.com/googlechrome/lighthouse/pull/6311))


move into docs

paulirish · 2018-10-31T17:33:02Z

changelog.md

+
+## Misc
+
+* proto: made default LighthouseError enum 'UNDEFINED' ([#6334](https://github.com/googlechrome/lighthouse/pull/6334))


move below with the proto block

paulirish · 2018-10-31T17:33:17Z

changelog.md

+* only allow 1 error from each audit/gatherer ([#6215](https://github.com/googlechrome/lighthouse/pull/6215))
+* Revert "core(driver): stringify protocol error messages (#6302)" ([#6328](https://github.com/googlechrome/lighthouse/pull/6328))
+* fix typo in feature request template ([#6431](https://github.com/googlechrome/lighthouse/pull/6431))
+* tests: run node 10 on Travis ([#6361](https://github.com/googlechrome/lighthouse/pull/6361))


this can move to be in Tests

paulirish · 2018-10-31T17:33:50Z

changelog.md

+* proto: reduce configSettings in proto to minimum ([88b2829](https://github.com/googlechrome/lighthouse/commit/88b2829))
+* yarn: update lockfile for micromatch ([#6384](https://github.com/googlechrome/lighthouse/pull/6384))
+
+## New Contributors!


throw this at the top! \o/

very very nice.

paulirish · 2018-10-31T17:35:07Z

changelog.md

+
+* offline-start-url ([#6397](https://github.com/googlechrome/lighthouse/pull/6397))
+
+## CLI


ive been ordering these sections with most important first.. so probably.. Core, Report, then errthing else.

paulirish · 2018-10-31T17:35:21Z

changelog.md

+* add primer on viewing the timing data ([#6393](https://github.com/googlechrome/lighthouse/pull/6393))
+* typo fix ([#6335](https://github.com/googlechrome/lighthouse/pull/6335))
+
+## Extension


can merge this and Clients now. yay

paulirish · 2018-10-31T17:35:40Z

changelog.md

+
+## CLI
+
+* docs: update docs for --output-path re: multiple output types ([#6339](https://github.com/googlechrome/lighthouse/pull/6339))


might as well toss into Docs section

paulirish · 2018-10-31T17:37:36Z

changelog.md

@@ -1,3 +1,144 @@
+ <a name="4.0.0-alpha.0"></a>
+# 4.0.0-alpha.0 (2018-10-31)
+[Full Changelog](https://github.com/googlechrome/lighthouse/compare/v3.2.0...v4.0.0-alpha.0)


we shipped 3.2.1 from a branch, so the compare wont work against it, but w/e.
technically these two commits aren't new to this rls.

should we just leave it as 3.2.0 ? with or without noting the technicality?

I think it's totally fine to ignore the technicality and leave as 3.2.0. If someone's very meticulous record keeping is thrown off, we'll just take the heat :)

paulirish · 2018-10-31T17:38:38Z

docs/releasing.md

@@ -70,6 +70,8 @@ echo "Test the lighthouse-viewer build"
 # Start a server in dist/viewer/ and open the page in a tab. You should see the viewer.


I guess you can remove this line and move 73/74 up here.
good hack with using static-server for this. :)

I assumed it was necessary ... I tried python -m SimpleHTTPServer first but I interpreted the viewer2x 400 error by thinking I need to use the static-server.

wdyt of instead suggesting cd dist/viewer ; python -m SimpleHTTPServer

paulirish · 2018-10-31T17:39:17Z

clients/extension/manifest.json

@@ -1,6 +1,6 @@
 {
  "name": "__MSG_appName__",
-  "version": "3.2.0",
+  "version": "3.3.0.4",


minor nit: i'd go with 3.3.0.4000 in case we have more alphas betas and we want to do 4001, etc

patrickhulce · 2018-10-31T18:15:36Z

changelog.md

+
+Thanks to @CodeDem for improving how the image-aspect-ratio audit handles small images!
+
+Huge thanks to myself (@Hoten) for joining Lighthouse! Go me!


patrickhulce · 2018-10-31T18:16:33Z

changelog.md

+
+Thanks to @CodeDem for improving how the image-aspect-ratio audit handles small images!
+
+Huge thanks to myself (@Hoten) for joining Lighthouse! Go me!


exterkamp · 2018-10-31T19:03:25Z

changelog.md

+
+Thanks to @CodeDem for improving how the image-aspect-ratio audit handles small images!
+
+Huge thanks to myself (@Hoten) for joining Lighthouse! Go me!


Back in my day we just let @paulirish release, and he never mentioned if you even existed. 👀

changelog.md

lighthouse-viewer/app/src/lighthouse-report-viewer.js

connorjclark · 2018-10-31T20:41:33Z

Travis is failing, not sure why.

EDIT: Paul ran it again. Worked this time.

4.0.0-alpha.0

44fbe45

connorjclark requested review from brendankenny, ebidel, exterkamp, patrickhulce and paulirish as code owners October 31, 2018 17:16

paulirish reviewed Oct 31, 2018

View reviewed changes

connorjclark added 2 commits October 31, 2018 11:14

pr changes, also include 3.2.1 changelog

54934bf

comp

1014164

patrickhulce reviewed Oct 31, 2018

View reviewed changes

exterkamp reviewed Oct 31, 2018

View reviewed changes

python

27f2e9b

paulirish approved these changes Nov 1, 2018

View reviewed changes

paulirish merged commit 40e1120 into master Nov 1, 2018

paulirish deleted the bumpv400alpha0 branch November 1, 2018 00:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4.0.0-alpha.0 #6434

4.0.0-alpha.0 #6434

connorjclark commented Oct 31, 2018

paulirish left a comment

paulirish Oct 31, 2018

paulirish Oct 31, 2018

paulirish Oct 31, 2018

paulirish Oct 31, 2018

paulirish Oct 31, 2018

paulirish Oct 31, 2018

paulirish Oct 31, 2018

paulirish Oct 31, 2018

connorjclark Oct 31, 2018

brendankenny Oct 31, 2018

paulirish Oct 31, 2018

connorjclark Oct 31, 2018

paulirish Oct 31, 2018

paulirish Oct 31, 2018

patrickhulce Oct 31, 2018

patrickhulce Oct 31, 2018

exterkamp Oct 31, 2018

connorjclark commented Oct 31, 2018 •

edited


		## Readme

		* Remove "sh" format for CLI --help output ([#6311](https://github.com/googlechrome/lighthouse/pull/6311))


		## Misc

		* proto: made default LighthouseError enum 'UNDEFINED' ([#6334](https://github.com/googlechrome/lighthouse/pull/6334))


		* offline-start-url ([#6397](https://github.com/googlechrome/lighthouse/pull/6397))

		## CLI


		## CLI

		* docs: update docs for --output-path re: multiple output types ([#6339](https://github.com/googlechrome/lighthouse/pull/6339))

		@@ -70,6 +70,8 @@ echo "Test the lighthouse-viewer build"
		# Start a server in dist/viewer/ and open the page in a tab. You should see the viewer.


		Thanks to @CodeDem for improving how the image-aspect-ratio audit handles small images!

		Huge thanks to myself (@Hoten) for joining Lighthouse! Go me!

4.0.0-alpha.0 #6434

4.0.0-alpha.0 #6434

Conversation

connorjclark commented Oct 31, 2018

paulirish left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

connorjclark commented Oct 31, 2018 • edited

connorjclark commented Oct 31, 2018 •

edited