Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: give passed-opportunities group an icon #6594

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented Nov 17, 2018

While we figure out #6568, fixes @patrickhulce's #6568 (comment)

The Opportunities group icon was being given to the old-style lh-audit-group--opportunities css class, but the Opportunities group under Passed had the new-style lh-audit-group--load-opportunities (lh-audit-group-- + groupId).

This PR just standardizes on the new style of class name.

Before:
screen shot 2018-11-16 at 17 52 51

After:
screen shot 2018-11-16 at 17 41 00

Copy link
Collaborator

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendankenny brendankenny merged commit 33ba60c into master Nov 19, 2018
@brendankenny brendankenny deleted the oppicon branch November 19, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants