core: rename webapp-install-banner audit to installable-manifest #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
exterkamp,
patrickhulce and
paulirish
as code owners
brendankenny
changed the title
31 tasks
patrickhulce
approved these changes
Nov 22, 2018
| @@ -933,6 +933,25 @@ | |||
| "scoreDisplayMode": "not_applicable", | |||
| "title": "`<input type=\"image\">` elements have `[alt]` text" | |||
| }, | |||
| "installable-manifest": { | |||
There was a problem hiding this comment.
interesting why did only these two swap order?
There was a problem hiding this comment.
looks like they're alphabetized. No idea why, but I guess it doesn't matter :) @exterkamp
gangsthub
added a commit
to gangsthub/WebFundamentals
that referenced
this pull request
Dec 4, 2018
File was renamed in GoogleChrome/lighthouse#6630
4 tasks
kaycebasques
pushed a commit
to google/WebFundamentals
that referenced
this pull request
Dec 4, 2018
File was renamed in GoogleChrome/lighthouse#6630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6395
Updates
webapp-install-bannerto be the newinstallable-manifestaudit. SW detection was already deleted from here, so this mostly just updates theidandtitleand tightens some tests/removes some useless stuff.