Recover if protocol DOM agent throws error about domain not being enabled #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what about doing it in place in return this.sendCommand('Debugger.disable')
.then(_ => {
return this.sendCommand('DOM.disable')
.catch(_ => {
// We proactively disable the DOM domain. Ignore any error.
});
}).then(_ => this.sendCommand('CSS.disable')) |
|
Good idea, done. I've left the small refactor in |
brendankenny
approved these changes
Oct 31, 2016
| log.formatProtocol('method <= browser ERR', | ||
| {method: callback.method}, 'error'); | ||
| callback.reject(object.error); | ||
| return; |
There was a problem hiding this comment.
don't need the return here
paulirish
force-pushed
the
permitDOMdomainerr
branch
from
9badef9
to
64870a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression we introduced in #830
DOM agent the only domain which complains if you attempt to disable when it was never enabled.
https://cs.chromium.org/search/?q=if.*!enabled+file:%5Esrc/third_party/WebKit/Source/core/inspector/+case:yes&sq=package:chromium&type=cs
This PR permits us to ignore these errors. And it should unbreak the
masterbuild.