Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: pwa #9105
i18n: pwa #9105
Changes from 16 commits
92fc46b
91d442d
56d0ca3
c9fb5d1
7dc454c
3828cd8
45e496c
8f0b99c
ee512e9
92261a6
61c0234
29e9468
da92533
e802f1a
64ae1b7
8ffcaee
f96c92c
ba1ba98
4ab1967
1fd1385
0e470cd
da299d9
227c97c
f2bb698
bf15438
27984af
f49735f
517efd7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't we sorta cheated similar to this in the past like in error messages? seems like we could do bullets or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaict we don't ever really use "failures" because it is just an auto combination of a list of strings into an explanation. I think we just use explanations manually in my experience. We might want to just migrate away from failures totally since this is all they do.
I added this to keep the PR scoped, but I think there is opportunity here for better i18n.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we tracking this in a mega i18n issue somewhere? if we intend to collect TODOs in the code, I wonder if it might be better to make them all
TODO(i18n)
or something easily findable when we need to make our next i18n impacting decisionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 we need a way to track this. I was also told that #7238 is super important for tracking this stuff, so let's actually track some of this stuff in there :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this edit from the original from an earlier discussion? It seems like a less universal thing to use as the incentive vs something like
"If you\'ve already set up HTTPS, make sure that you redirect all HTTP traffic to HTTPS in order to keep acess to your site secure"
or whatever.(If you want to keep this version, it should at least be "in order to enable secure web features...")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to remember saying something like this. It seems to me that in the context of PWA the primary reason you care about this is for using a service worker for all your visitors. That's a very concrete and specific carrot compared to "make it secure so that it will be secure" but 🤷♂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well the most important reason to make it secure is so it will be secure :D but very good point about the context and the whole point is to be checking something a dev might forgot to check that will undermine other things they're trying to do. So change SGTM, but still needs the typo fix