i18n: pwa #9105

exterkamp · 2019-06-02T19:18:51Z

Summary
i18n PWA! 🇺🇸 🇵🇷 🇦🇸 🇪🇺 🇨🇳 🇮🇳 🇩🇪 🇧🇷

TODO

~~merge changes from i18n: localize audits in best-practices #9092~~

Follow up:

Move all PWA audits into a pwa/ folder

Part of: #7238
fixes: #9530

lighthouse-core/audits/content-width.js

lighthouse-core/audits/themed-omnibox.js

lighthouse-core/audits/works-offline.js

patrickhulce

exterkamp (n.) an i18n phenom

lighthouse-core/audits/content-width.js

patrickhulce · 2019-06-03T18:57:00Z

lighthouse-core/audits/is-on-https.js

+    'in on the communications between your app and your users, and is a prerequisite for ' +
+    'HTTP/2 and many new web platform APIs. ' +
+    '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/https).',
+  displayValue: `{itemCount, plural,


just for my personal clarity, this is one that would be preserved in the new proposal as "real" ICU syntax for translators?

Yes, this is sent to the translators as "real" ICU. Plurals, and ordinals are the only* ICU syntax passed on.

*afaik

lighthouse-core/audits/is-on-https.js

patrickhulce · 2019-06-03T18:58:32Z

lighthouse-core/audits/multi-check-audit.js

@@ -53,6 +53,7 @@ class MultiCheckAudit extends Audit {
    if (result.failures.length > 0) {
      return {
        score: 0,
+        // TODO(exterkamp): make this i18n-able.


haven't we sorta cheated similar to this in the past like in error messages? seems like we could do bullets or something

Afaict we don't ever really use "failures" because it is just an auto combination of a list of strings into an explanation. I think we just use explanations manually in my experience. We might want to just migrate away from failures totally since this is all they do.

I added this to keep the PR scoped, but I think there is opportunity here for better i18n.

are we tracking this in a mega i18n issue somewhere? if we intend to collect TODOs in the code, I wonder if it might be better to make them all TODO(i18n) or something easily findable when we need to make our next i18n impacting decisions

+1 we need a way to track this. I was also told that #7238 is super important for tracking this stuff, so let's actually track some of this stuff in there :P

lighthouse-core/audits/works-offline.js

…ad of non-pruned list.

exterkamp · 2019-06-03T20:30:54Z

lighthouse-core/audits/is-on-https.js

@@ -53,18 +64,16 @@ class HTTPS extends Audit {
          .filter(record => !HTTPS.isSecureRecord(record))
          .map(record => URL.elideDataURI(record.url));

+      const items = Array.from(new Set(insecureURLs)).map(url => ({url}));


Moved this to before displayValue calc so that the display value # matches the de-duplicated item count.

lighthouse-core/audits/installable-manifest.js

brendankenny · 2019-08-07T00:15:58Z

lighthouse-core/audits/redirects-http.js

+  failureTitle: 'Does not redirect HTTP traffic to HTTPS',
+  /** Description of a Lighthouse audit that tells the user why they should direct HTTP traffic to HTTPS. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
+  description: 'If you\'ve already set up HTTPS, make sure that you redirect all HTTP ' +
+    'traffic to HTTPS in order enable secure web features for all your users. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-redirects-to-https).',


was this edit from the original from an earlier discussion? It seems like a less universal thing to use as the incentive vs something like "If you\'ve already set up HTTPS, make sure that you redirect all HTTP traffic to HTTPS in order to keep acess to your site secure" or whatever.

(If you want to keep this version, it should at least be "in order to enable secure web features...")

I seem to remember saying something like this. It seems to me that in the context of PWA the primary reason you care about this is for using a service worker for all your visitors. That's a very concrete and specific carrot compared to "make it secure so that it will be secure" but 🤷‍♂

I seem to remember saying something like this. It seems to me that in the context of PWA the primary reason you care about this is for using a service worker for all your visitors. That's a very concrete and specific carrot compared to "make it secure so that it will be secure" but 🤷‍♂

well the most important reason to make it secure is so it will be secure :D but very good point about the context and the whole point is to be checking something a dev might forgot to check that will undermine other things they're trying to do. So change SGTM, but still needs the typo fix

Suggested change

'traffic to HTTPS in order enable secure web features for all your users. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-redirects-to-https).',

'traffic to HTTPS in order to enable secure web features for all your users. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-redirects-to-https).',

lighthouse-core/test/audits/offline-start-url-test.js

lighthouse-core/audits/manual/pwa-page-transitions.js

lighthouse-core/audits/service-worker.js

Co-Authored-By: Brendan Kenny <bckenny@gmail.com>

paulirish · 2019-08-06T22:52:55Z

lighthouse-core/audits/multi-check-audit.js

@@ -53,6 +53,7 @@ class MultiCheckAudit extends Audit {
    if (result.failures.length > 0) {
      return {
        score: 0,
+        // TODO(#7238): make this i18n-able.


brendankenny · 2019-08-08T19:49:08Z

I also noticed the apple-touch-icon PWA audit has some issues with its description (apple-touch-icon should really be backticked and maybe an object for what's being added to the homescreen?)

exterkamp · 2019-08-08T22:41:29Z

I also noticed the apple-touch-icon PWA audit has some issues with its description (apple-touch-icon should really be backticked and maybe an object for what's being added to the homescreen?)

Done. Added fixes to PR description.

brendankenny

we could live with the (current) apple-touch-icon.js indentation, but also need that "to" in redirects-http.js :)

otherwise LGTM! 🎉

lighthouse-core/audits/apple-touch-icon.js

lighthouse-core/audits/redirects-http.js

initial strings and tests

92fc46b

connorjclark reviewed Jun 3, 2019

View reviewed changes

lighthouse-core/audits/content-width.js Outdated Show resolved Hide resolved

connorjclark reviewed Jun 3, 2019

View reviewed changes

lighthouse-core/audits/content-width.js Show resolved Hide resolved

connorjclark reviewed Jun 3, 2019

View reviewed changes

lighthouse-core/audits/themed-omnibox.js Outdated Show resolved Hide resolved

connorjclark reviewed Jun 3, 2019

View reviewed changes

lighthouse-core/audits/works-offline.js Outdated Show resolved Hide resolved

patrickhulce reviewed Jun 3, 2019

View reviewed changes

String feedback

91d442d

googlebot added the cla: yes label Jun 3, 2019

vercel bot deployed to staging June 3, 2019 20:19 View deployment

Changed wording and updated tests. Is-on-https use items.length inste…

56d0ca3

…ad of non-pruned list.

vercel bot deployed to staging June 3, 2019 20:30 View deployment

exterkamp commented Jun 3, 2019

View reviewed changes

Added descriptions

c9fb5d1

vercel bot deployed to staging June 3, 2019 21:17 View deployment

missed one

7dc454c

vercel bot deployed to staging June 3, 2019 21:21 View deployment

exterkamp added the i18n internationalization thangs label Jun 4, 2019

Removed comma.

3828cd8

vercel bot deployed to staging June 4, 2019 16:38 View deployment

themed omnibox more clear

45e496c

vercel bot deployed to staging June 4, 2019 16:42 View deployment

paulirish mentioned this pull request Jun 6, 2019

Internationalization of Lighthouse (Phase 2) #7238

Closed

36 tasks

Merge branch 'master' into pwa_i18n

8f0b99c

vercel bot deployed to staging June 25, 2019 21:16 View deployment

revert nulls in proto sample

ee512e9

vercel bot deployed to staging June 25, 2019 21:20 View deployment

exterkamp marked this pull request as ready for review June 25, 2019 21:32

exterkamp requested a review from paulirish as a code owner June 25, 2019 21:32

exterkamp requested a review from brendankenny June 25, 2019 21:33

Merge branch 'master' into pwa_i18n

92261a6

manual audit desc rewording

1fd1385

vercel bot deployed to staging August 1, 2019 17:17 View deployment

exterkamp mentioned this pull request Aug 1, 2019

I18N: Missing translations for audits #9492

Closed

brendankenny removed the waiting4review label Aug 1, 2019

exterkamp added the waiting4review label Aug 6, 2019

brendankenny reviewed Aug 7, 2019

View reviewed changes

Apply Brendan's suggestions from code review

0e470cd

Co-Authored-By: Brendan Kenny <bckenny@gmail.com>

vercel bot deployed to staging August 7, 2019 20:47 View deployment

updating en and en-xl with new strings

da299d9

vercel bot deployed to staging August 7, 2019 20:53 View deployment

update tests, update sample json, fix linting.

227c97c

vercel bot deployed to staging August 7, 2019 21:35 View deployment

exterkamp added 3 commits August 7, 2019 15:00

fixed offline-start-url test

f2bb698

TODO to issue from username

bf15438

add viewport code spans!

27984af

vercel bot deployed to staging August 7, 2019 22:05 View deployment

brendankenny removed the waiting4review label Aug 7, 2019

paulirish reviewed Aug 7, 2019

View reviewed changes

better apple-touch-icon desc

f49735f

vercel bot deployed to staging August 8, 2019 22:32 View deployment

brendankenny approved these changes Aug 8, 2019

View reviewed changes

lighthouse-core/audits/apple-touch-icon.js Outdated Show resolved Hide resolved

lighthouse-core/audits/redirects-http.js Outdated Show resolved Hide resolved

brendan last nits

517efd7

vercel bot deployed to staging August 9, 2019 16:18 View deployment

brendankenny merged commit 7e5fcf6 into master Aug 9, 2019

brendankenny deleted the pwa_i18n branch August 9, 2019 19:46

paulirish pushed a commit that referenced this pull request Nov 6, 2019

i18n: move pwa audits to i18n system (#9105)

9e87b05

snyk-bot mentioned this pull request Mar 21, 2020

[Snyk] Upgrade lighthouse from 5.1.0 to 5.6.0 godaddy/lighthouse4u#13

Merged

connorjclark mentioned this pull request Sep 21, 2020

core(is-on-https): add missing space in description #11466

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

i18n: pwa #9105

i18n: pwa #9105

exterkamp commented Jun 2, 2019 •

edited

Loading

patrickhulce left a comment

patrickhulce Jun 3, 2019

exterkamp Jun 3, 2019

patrickhulce Jun 3, 2019

exterkamp Jun 3, 2019

patrickhulce Jul 25, 2019

patrickhulce Jul 30, 2019

brendankenny Jul 31, 2019

exterkamp Jun 3, 2019

brendankenny Aug 7, 2019

patrickhulce Aug 7, 2019

brendankenny Aug 7, 2019

paulirish Aug 6, 2019

brendankenny commented Aug 8, 2019

exterkamp commented Aug 8, 2019

brendankenny left a comment

	'traffic to HTTPS in order enable secure web features for all your users. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-redirects-to-https).',
	'traffic to HTTPS in order to enable secure web features for all your users. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/http-redirects-to-https).',

i18n: pwa #9105

i18n: pwa #9105

Conversation

exterkamp commented Jun 2, 2019 • edited Loading

patrickhulce left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brendankenny commented Aug 8, 2019

exterkamp commented Aug 8, 2019

brendankenny left a comment

Choose a reason for hiding this comment

exterkamp commented Jun 2, 2019 •

edited

Loading