Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Close page after screenshot to avoid memory leak #292

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

mikaraunio
Copy link
Contributor

This PR fixes a memory leak when rendering page screenshots. Renderer.screenshot() doesn't close the page on completion (even if successful), thus leaving renderer processes behind.

Follows along the lines of #268

@mikaraunio mikaraunio requested a review from AVGP as a code owner May 31, 2019 18:58
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mikaraunio
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@AVGP AVGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me!

@AVGP
Copy link
Collaborator

AVGP commented Aug 31, 2019

@mikaraunio Thank you so much for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants