Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A minimal App Install Banner demo #83

Merged
merged 4 commits into from
Mar 2, 2015

Conversation

PaulKinlan
Copy link
Member

This went through a couple of changes as I worked with the eng team to diagnose a critical bug.

This now works. @addyosmani @jeffposnick would love a review so I can get it in to the post about this feature.

Merge in all the latest latest jazz.
@addyosmani
Copy link
Member

Nice work, Paul. Happy to review further. Could you squash your commits please? :) I have a few questions (e.g why we're using <meta name="viewport" content="width=device-width"> rather than the complete one, but can save till squashed).

@PaulKinlan
Copy link
Member Author

How does one squas commits in the Chrome Dev Tools editor and in the github interface?

@addyosmani
Copy link
Member

Updating some bits

Simple fix

Some minor changes.

test

The bug in Chrome has been fixed, returning to 'type'
@PaulKinlan
Copy link
Member Author

It does not, I pulled it all in locally on another machine and squashed there instead. I can't get rid of the merge commit.

@PaulKinlan
Copy link
Member Author

Nope. however it was copied from one of the SW examples. Will sort.

@addyosmani
Copy link
Member

Reviewed. One other minor comment: we usually include a brief description of the feature https://github.com/GoogleChrome/samples/blob/gh-pages/lexical-declarations-es6/index.html#L49 along with its name (heading) and any other posts or ChromeStatus links (https://www.chromestatus.com/features/4540065577435136) we want to reference at the start of the sample.

Also mention which version of Chrome and above one can expect this to work in. Could we do this?

@PaulKinlan
Copy link
Member Author

Sure I can do this, I mostly copied the formatting and style from another example. Will add them.

@addyosmani
Copy link
Member

Thank you 🍰

@addyosmani
Copy link
Member

One last comment.

@PaulKinlan
Copy link
Member Author

Sorted typo

addyosmani added a commit that referenced this pull request Mar 2, 2015
A minimal App Install Banner demo
@addyosmani addyosmani merged commit 18fc75f into GoogleChrome:gh-pages Mar 2, 2015
@addyosmani
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants